rdblue commented on code in PR #13219:
URL: https://github.com/apache/iceberg/pull/13219#discussion_r2229653096
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/data/TestHelpers.java:
##########
@@ -428,6 +430,12 @@ private static void assertEqualsUnsafe(Type type, Object
expected, Object actual
assertThat(actual).as("Should be an
ArrayBasedMapData").isInstanceOf(MapData.class);
assertEqualsUnsafe(type.asNestedType().asMapType(), (Map<?, ?>)
expected, (MapData) actual);
break;
+ case VARIANT:
+ assertThat(expected).as("Should expect a
Variant").isInstanceOf(Variant.class);
+ assertThat(actual).as("Should be a
Variant").isInstanceOf(Variant.class);
+ VariantTestUtil.assertEqual(((Variant) expected).metadata(),
((Variant) actual).metadata());
+ VariantTestUtil.assertEqual(((Variant) expected).value(), ((Variant)
actual).value());
Review Comment:
Looks like this isn't correct. An `InternalRow` will represent the value as
`VariantVal` so this is the correct validation:
```java
case VARIANT:
assertThat(expected).as("Should expect a
Variant").isInstanceOf(Variant.class);
assertThat(actual).as("Should be a
Variant").isInstanceOf(VariantVal.class);
VariantVal actualVariant = (VariantVal) actual;
VariantMetadata actualMetadata =
VariantMetadata.from(
ByteBuffer.wrap(actualVariant.getMetadata()).order(ByteOrder.LITTLE_ENDIAN));
VariantValue actualValue =
VariantValue.from(
actualMetadata,
ByteBuffer.wrap(actualVariant.getValue()).order(ByteOrder.LITTLE_ENDIAN));
VariantTestUtil.assertEqual(((Variant) expected).metadata(),
actualMetadata);
VariantTestUtil.assertEqual(((Variant) expected).value(),
actualValue);
break;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
