aihuaxu commented on code in PR #13219:
URL: https://github.com/apache/iceberg/pull/13219#discussion_r2207930519


##########
parquet/src/main/java/org/apache/iceberg/parquet/TripleIterator.java:
##########
@@ -21,7 +21,7 @@
 import java.util.Iterator;
 import org.apache.parquet.io.api.Binary;
 
-interface TripleIterator<T> extends Iterator<T> {
+public interface TripleIterator<T> extends Iterator<T> {

Review Comment:
   I updated to use DelegatingValueReader. We need to change 
DelegatingValueReader to public in order to be used in `SparkParquetReaders`. 
But you will get a warning  in the DelegatingValueReader interface that this 
class is exposed outside of its visibility. I think we still need to change 
TripleIterator to public.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to