aihuaxu commented on PR #13219:
URL: https://github.com/apache/iceberg/pull/13219#issuecomment-3070819690

   > @aihuaxu, I caught up with @danielcweeks about this yesterday and I think 
his concern was that we need to support reading shredded values. It would be 
nice to be able to write them as well, but I think as long as this can read 
them (and we have a test to validate it) then we should be able to move forward 
with this. Thanks for your patience on this while I was out at conferences!
   
   I have added a test case to read from shredded variant. I didn't add 
multiple test cases like TestVariantReaders but just added one. We will use 
ParquetVariantReaders to read and convert to VariantVal so the logic should 
have been covered by the existing TestVariantReaders.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to