nastra commented on code in PR #13244:
URL: https://github.com/apache/iceberg/pull/13244#discussion_r2131610832
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIO.java:
##########
@@ -443,55 +445,53 @@ public void testFileIOJsonSerialization() {
}
}
- @Test
- public void testS3FileIOKryoSerialization() throws IOException {
+ @ParameterizedTest
+ @MethodSource("org.apache.iceberg.TestHelpers#serializers")
+ public void
testS3FileIOSerialization(TestHelpers.RoundTripSerializer<FileIO>
roundTripSerializer)
+ throws IOException, ClassNotFoundException {
FileIO testS3FileIO = new S3FileIO();
// s3 fileIO should be serializable when properties are passed as
immutable map
testS3FileIO.initialize(ImmutableMap.of("k1", "v1"));
Review Comment:
```suggestion
testS3FileIO.initialize(ImmutableMap.of("k1", "v1", "k2", "v2"));
```
this suggestion isn't strictly related to the scope of the PR but let's
change it anyway here. In #12882 I've found out that Kryo serde behaves
differently when only a single key/value pair are passed in a map and it would
be good to update this place here to use 2 key/value pairs for testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
