nandorKollar commented on PR #13244: URL: https://github.com/apache/iceberg/pull/13244#issuecomment-2948593107
> @nandorKollar can you also please update `TestAwsProperties` / `TestAwsClientFactories`/ `TestTableSerialization` (in core). Those places also use kryo serde and it would be good to test those places with kryo/java serde. Please also do the same in > > https://github.com/apache/iceberg/blob/68f8053d67aaae7c7cf7b13045e2ed4146fa45f9/azure/src/test/java/org/apache/iceberg/azure/AzurePropertiesTest.java#L64 Actually I wanted to bring this up, I found places where the test only test either for Kryo or for Java, but not for both. Sure, I can make the parametrised, that would also increase somewhat the coverage too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
