nastra commented on code in PR #13244:
URL: https://github.com/apache/iceberg/pull/13244#discussion_r2128771777
##########
core/src/test/java/org/apache/iceberg/hadoop/HadoopFileIOTest.java:
##########
@@ -143,24 +158,17 @@ public void testDeleteFilesErrorHandling() {
.hasMessage("Failed to delete 2 files");
}
- @Test
- public void testHadoopFileIOKryoSerialization() throws IOException {
- FileIO testHadoopFileIO = new HadoopFileIO();
+ @ParameterizedTest
+ @MethodSource("serializers")
+ public void testHadoopFileIOSerialization(
+ TestHelpers.RoundTripSerializerFunction<FileIO>
roundTripSerializerFunction)
Review Comment:
minor: I would just omit the `Function` part both in the interface name and
in the var name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
