nandorKollar commented on PR #13244:
URL: https://github.com/apache/iceberg/pull/13244#issuecomment-2949084119
> thanks @nandorKollar, this looks great!
@nastra I still missed one class, `TestTableSerialization`, where I got a
bit confused.
I found a test like this one:
```
@Test
public void testSerializableTableWithSnapshot() throws IOException,
ClassNotFoundException {
table.newAppend().appendFile(FILE_A).commit();
TestHelpers.assertSerializedAndLoadedMetadata(table,
TestHelpers.roundTripSerialize(table));
Table serializableTable = SerializableTable.copyOf(table);
TestHelpers.assertSerializedAndLoadedMetadata(
serializableTable,
TestHelpers.KryoHelpers.roundTripSerialize(serializableTable));
}
```
Do you happen to know, why the first one
`TestHelpers.assertSerializedAndLoadedMetadata(table,
TestHelpers.roundTripSerialize(table))` serializes the original table, but the
second one the Serializable copy of it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
