nastra commented on code in PR #13244:
URL: https://github.com/apache/iceberg/pull/13244#discussion_r2128775617


##########
gcp/src/test/java/org/apache/iceberg/gcp/gcs/GCSFileIOTest.java:
##########
@@ -70,6 +75,16 @@ public class GCSFileIOTest {
   private final Storage storage = 
spy(LocalStorageHelper.getOptions().getService());
   private GCSFileIO io;
 
+  private static <T> Stream<Arguments> serializers() {

Review Comment:
   what about moving this to `TestHelpers`. You should be able to refer to this 
via the fully-qualified name of the class + method name in all of the tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to