liziyan-lzy commented on PR #12254: URL: https://github.com/apache/iceberg/pull/12254#issuecomment-2933062276
> > Hi @pvary , I've noticed there are some conflicts in this PR. Would you recommend that I rebase onto the current main branch and resolve conflicts? > > Definitely do it please. We can't merge with conflicts 😄 > > > Also, I see Spark 4.0 is now the default version. Should we keep these changes focused on the current target version and create a follow-up PR for Spark 4.0 compatibility？ Thanks for your guidance! > > Since rebase is needed anyway, you might be able to move the changes to Spark 4.0. If you find it difficult, we can merge this to Spark 3.5, and then port the changes to the other supported versions. > > We generally try to work on the latest version, so the changes slowly make to all of the supported versions. Even if we forget to backport the changes. But this one is only the backup plan. The work is finished on a feature when it is ported to every supported version. Hi, I have resolved the merge conflicts. Would it make sense to first land this in Spark 3.5, then create a subsequent PR to port these changes to our other supported version branches? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
