RussellSpitzer commented on code in PR #12254:
URL: https://github.com/apache/iceberg/pull/12254#discussion_r2112725064
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##########
@@ -344,6 +374,8 @@ public void testWapFilesAreKept() {
// wap write
df.select("c1", "c2",
"c3").write().format("iceberg").mode("append").save(tableLocation);
+ spark.conf().unset(SparkSQLProperties.WAP_ID);
Review Comment:
We should be using withSQLConf then for this test then like
```java
withSQLConf(Map.of(SparkSQLProperties.WAP_ID, "1"), () -> {
// wap write
df.select("c1", "c2",
"c3").write().format("iceberg").mode("append").save(tableLocation);
Dataset<Row> resultDF =
spark.read().format("iceberg").load(tableLocation);
List<ThreeColumnRecord> actualRecords =
resultDF.as(Encoders.bean(ThreeColumnRecord.class)).collectAsList();
// TODO: currently fails because DVs delete stuff from WAP branch
assertThat(actualRecords)
.as("Should not return data from the staged snapshot")
.isEqualTo(records);
});
```
or a cloned Spark Session
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
