RussellSpitzer commented on code in PR #12254:
URL: https://github.com/apache/iceberg/pull/12254#discussion_r2112716340
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##########
@@ -107,9 +115,12 @@ public abstract class TestRemoveOrphanFilesAction extends
TestBase {
protected Map<String, String> properties;
@Parameter private int formatVersion;
- @Parameters(name = "formatVersion = {0}")
+ @Parameter(index = 1)
+ private boolean usePrefixListing;
+
+ @Parameters(name = "formatVersion = {0}, usePrefixListing = {1}")
protected static List<Object> parameters() {
- return Arrays.asList(2, 3);
+ return Arrays.asList(new Object[] {2, true}, new Object[] {2, false}, new
Object[] {3, false});
Review Comment:
I mostly just don't want to have another explicit "version number" I'm fine
if we even only test on the default version number really.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
