liziyan-lzy commented on code in PR #12254:
URL: https://github.com/apache/iceberg/pull/12254#discussion_r2113180858
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##########
@@ -107,9 +115,12 @@ public abstract class TestRemoveOrphanFilesAction extends
TestBase {
protected Map<String, String> properties;
@Parameter private int formatVersion;
- @Parameters(name = "formatVersion = {0}")
+ @Parameter(index = 1)
+ private boolean usePrefixListing;
+
+ @Parameters(name = "formatVersion = {0}, usePrefixListing = {1}")
protected static List<Object> parameters() {
- return Arrays.asList(2, 3);
+ return Arrays.asList(new Object[] {2, true}, new Object[] {2, false}, new
Object[] {3, false});
Review Comment:
Thank you all for the discussion. I've updated the implementation to include
all versions from TestHelpers.ALL_VERSIONS. The current test matrix maintains
coverage for both prefix listing enabled and disabled cases, while optimizing
execution by skipping redundant test cases from previous commits.
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##########
@@ -344,6 +374,8 @@ public void testWapFilesAreKept() {
// wap write
df.select("c1", "c2",
"c3").write().format("iceberg").mode("append").save(tableLocation);
+ spark.conf().unset(SparkSQLProperties.WAP_ID);
Review Comment:
Fixed. Used withSQLConf as suggested. Thanks for your guidance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
