liziyan-lzy commented on code in PR #12254:
URL: https://github.com/apache/iceberg/pull/12254#discussion_r2111137789
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##########
@@ -344,6 +374,8 @@ public void testWapFilesAreKept() {
// wap write
df.select("c1", "c2",
"c3").write().format("iceberg").mode("append").save(tableLocation);
+ spark.conf().unset(SparkSQLProperties.WAP_ID);
Review Comment:
This configuration may cause test failures if enabled during multiple test
runs. It is added to ensure that this configuration is removed after each test
completes.
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##########
@@ -1067,6 +1148,38 @@ public void testRemoveOrphanFileActionWithDeleteMode() {
DeleteOrphanFiles.PrefixMismatchMode.DELETE);
}
+ @TestTemplate
+ public void testDefaultToHadoopListing() {
+ assumeThat(usePrefixListing)
+ .as("Should not test both prefix listing and Hadoop file listing
(redundant)")
Review Comment:
Fixed. Thanks for pointing this out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
