elphastori commented on code in PR #13129: URL: https://github.com/apache/iceberg/pull/13129#discussion_r2120645511
########## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ########## @@ -268,13 +268,12 @@ public List<TableIdentifier> listTables(SessionContext context, Namespace ns) { checkNamespaceIsValid(ns); Map<String, String> queryParams = Maps.newHashMap(); ImmutableList.Builder<TableIdentifier> tables = ImmutableList.builder(); - String pageToken = ""; + String pageToken = null; Review Comment: This specific change is only cosmetic, whether we have an empty string or a null, the logic doesn't include the parameter on the first request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org