elphastori commented on code in PR #13129:
URL: https://github.com/apache/iceberg/pull/13129#discussion_r2120779929
##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -111,7 +111,8 @@ public CommitFailedException wrapped() {
}
private static <T> Pair<List<T>, String> paginate(List<T> list, String
pageToken, int pageSize) {
- int pageStart = INITIAL_PAGE_TOKEN.equals(pageToken) ? 0 :
Integer.parseInt(pageToken);
+ int pageStart =
Review Comment:
Thanks! I definitely underestimated how hard that line was to read. Your
suggestion was great, I’ve taken it a step further, and I think this version is
even more readable now:
```
private static <T> Pair<List<T>, String> paginate(List<T> list, String
pageToken, int pageSize) {
boolean isFirstPage = pageToken == null ||
pageToken.equals(INITIAL_PAGE_TOKEN);
int pageStart = isFirstPage ? 0 : Integer.parseInt(pageToken);
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
