kevinjqliu commented on code in PR #13129:
URL: https://github.com/apache/iceberg/pull/13129#discussion_r2110923274
##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -111,6 +111,10 @@ public CommitFailedException wrapped() {
}
private static <T> Pair<List<T>, String> paginate(List<T> list, String
pageToken, int pageSize) {
+ if (pageToken == null) {
+ pageToken = INITIAL_PAGE_TOKEN;
Review Comment:
Looks like java checkstyle doesn't like parameter reassignement,
```
> Task :iceberg-core:showDeprecationRulesOnRevApiFailure SKIPPED
Error: eckstyle] [ERROR]
/home/runner/work/iceberg/iceberg/core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:115:17:
Assignment of parameter 'pageToken' is not allowed. [ParameterAssignment]
```
Let's go back to the previous implementation
```
int start = (pageToken == null || INITIAL_PAGE_TOKEN.equals(pageToken)) ? 0
: Integer.parseInt(pageToken);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
