nastra commented on code in PR #13129:
URL: https://github.com/apache/iceberg/pull/13129#discussion_r2120549500
##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -111,7 +111,8 @@ public CommitFailedException wrapped() {
}
private static <T> Pair<List<T>, String> paginate(List<T> list, String
pageToken, int pageSize) {
- int pageStart = INITIAL_PAGE_TOKEN.equals(pageToken) ? 0 :
Integer.parseInt(pageToken);
+ int pageStart =
Review Comment:
maybe update this to
```
private static <T> Pair<List<T>, String> paginate(List<T> list, String
pageToken, int pageSize) {
- int pageStart = INITIAL_PAGE_TOKEN.equals(pageToken) ? 0 :
Integer.parseInt(pageToken);
+ String token = null == pageToken ? INITIAL_PAGE_TOKEN : pageToken;
+ int pageStart = INITIAL_PAGE_TOKEN.equals(token) ? 0 :
Integer.parseInt(token);
```
to make it slightly more readable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
