nastra commented on code in PR #13129:
URL: https://github.com/apache/iceberg/pull/13129#discussion_r2120983222
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -268,13 +268,12 @@ public List<TableIdentifier> listTables(SessionContext
context, Namespace ns) {
checkNamespaceIsValid(ns);
Map<String, String> queryParams = Maps.newHashMap();
ImmutableList.Builder<TableIdentifier> tables = ImmutableList.builder();
- String pageToken = "";
+ String pageToken = null;
Review Comment:
> I'm thinking of reverting all my changes to RESTSessionCatalog, since I
only modified it because it's used by the unit tests. That would mean reverting
the related test changes as well.
Yes it's best to revert those changes. We'll have to see whether there's an
easy option on how to properly test this in a separate unit test (outside of
`TestRESTCatalog` / `TestRESTViewCatalog`) if possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
