pvary commented on code in PR #13072:
URL: https://github.com/apache/iceberg/pull/13072#discussion_r2100544417


##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java:
##########
@@ -192,7 +222,9 @@ public static Type convert(LogicalType flinkType) {
    *
    * @param rowType a RowType
    * @return Flink TableSchema
+   * @deprecated use {@link #toResolvedSchema(RowType)} instead
    */
+  @Deprecated
   public static TableSchema toSchema(RowType rowType) {

Review Comment:
   If we think that this is not used outside of the tests, and not useful for 
users, then we can mark as deprecated, and decrease the visibility in the 1.11 
or later releases



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to