mxm commented on code in PR #13072:
URL: https://github.com/apache/iceberg/pull/13072#discussion_r2097561070
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java:
##########
@@ -192,7 +222,9 @@ public static Type convert(LogicalType flinkType) {
*
* @param rowType a RowType
* @return Flink TableSchema
+ * @deprecated use {@link #toResolvedSchema(RowType)} instead
*/
+ @Deprecated
public static TableSchema toSchema(RowType rowType) {
Review Comment:
Should we get rid of this? AFAIK This is only used in tests.
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java:
##########
@@ -137,7 +136,9 @@ private static Schema freshIdentifierFieldIds(Schema
icebergSchema, List<String>
* @param flinkSchema a Flink TableSchema
* @return the equivalent Schema
* @throws IllegalArgumentException if the type cannot be converted or there
are missing ids
+ * @deprecated use {@link #convert(Schema, ResolvedSchema)} instead.
*/
+ @Deprecated
public static Schema convert(Schema baseSchema, TableSchema flinkSchema) {
Review Comment:
Should we get rid of this method, at least for 2.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
