liamzwbao commented on code in PR #13072:
URL: https://github.com/apache/iceberg/pull/13072#discussion_r2108061992
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java:
##########
@@ -192,7 +222,9 @@ public static Type convert(LogicalType flinkType) {
*
* @param rowType a RowType
* @return Flink TableSchema
+ * @deprecated use {@link #toResolvedSchema(RowType)} instead
*/
+ @Deprecated
public static TableSchema toSchema(RowType rowType) {
Review Comment:
Hi Peter! Yes, we don't need validations for watermarks and primary keys for
this method, the only thing we need is duplication check.
But there is another
[toSchema](https://github.com/apache/iceberg/blob/5d2c014ad51028dccd049b447619e08f90bb560e/flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java#L260-L283)
in this util that I plan to deprecate in the next PR. That one does require a
primary key check, and I’m wondering whether we should implement that check
manually or rely on something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
