pvary commented on code in PR #13072:
URL: https://github.com/apache/iceberg/pull/13072#discussion_r2097840795
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java:
##########
@@ -137,7 +136,9 @@ private static Schema freshIdentifierFieldIds(Schema
icebergSchema, List<String>
* @param flinkSchema a Flink TableSchema
* @return the equivalent Schema
* @throws IllegalArgumentException if the type cannot be converted or there
are missing ids
+ * @deprecated use {@link #convert(Schema, ResolvedSchema)} instead.
*/
+ @Deprecated
public static Schema convert(Schema baseSchema, TableSchema flinkSchema) {
Review Comment:
I would try to keep the Flink 2.0 and 1.19/1.18 code as similar as possible,
so we will not have problems with the backports between the different branches.
So if this PR is working for 1.19/1.18, then I'm fine with deprecating, and
later removing methods, but if not, then I would keep them until the all the
Flink versions not supporting them is deprecated.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
