pvary commented on code in PR #13072:
URL: https://github.com/apache/iceberg/pull/13072#discussion_r2100550906
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java:
##########
@@ -137,7 +136,9 @@ private static Schema freshIdentifierFieldIds(Schema
icebergSchema, List<String>
* @param flinkSchema a Flink TableSchema
* @return the equivalent Schema
* @throws IllegalArgumentException if the type cannot be converted or there
are missing ids
+ * @deprecated use {@link #convert(Schema, ResolvedSchema)} instead.
*/
+ @Deprecated
public static Schema convert(Schema baseSchema, TableSchema flinkSchema) {
Review Comment:
Yes, that would be nice.
We usually stick to Flink-like deprecation periods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
