nastra commented on code in PR #13021:
URL: https://github.com/apache/iceberg/pull/13021#discussion_r2093318132
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##########
@@ -314,20 +313,6 @@ private void
createBoundedStreams(StreamExecutionEnvironment env, int failAfter)
// test utilities copied from Flink's FileSourceTextLinesITCase
// ------------------------------------------------------------------------
- private static void runTestWithNewMiniCluster(ThrowingConsumer<MiniCluster,
Exception> testMethod)
- throws Exception {
- MiniClusterWithClientResource miniCluster = null;
- try {
- miniCluster = new
MiniClusterWithClientResource(MINI_CLUSTER_RESOURCE_CONFIG);
Review Comment:
@JeonDaehong no worries at all. Basically your change here makes sense and
we should get it in once tests are passing. The idea was also to exclude JUnit
4 from the Flink testing dependencies but I don't think this is currently
possible, which you've already seen via the error in
https://github.com/apache/iceberg/pull/13021#discussion_r2086799436.
Everything else was already handled in
https://github.com/apache/iceberg/pull/12938 and I've opened
https://github.com/apache/iceberg/issues/13049 as a long-term goal that we'd
eventually like to have (but that's quite difficult right now because there are
still some dependencies that pull in JUnit4 themselves)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
