tomtongue commented on code in PR #13021:
URL: https://github.com/apache/iceberg/pull/13021#discussion_r2084943751
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##########
@@ -314,20 +313,6 @@ private void
createBoundedStreams(StreamExecutionEnvironment env, int failAfter)
// test utilities copied from Flink's FileSourceTextLinesITCase
// ------------------------------------------------------------------------
- private static void runTestWithNewMiniCluster(ThrowingConsumer<MiniCluster,
Exception> testMethod)
- throws Exception {
- MiniClusterWithClientResource miniCluster = null;
- try {
- miniCluster = new
MiniClusterWithClientResource(MINI_CLUSTER_RESOURCE_CONFIG);
Review Comment:
@nastra What do you think about adding this cluster start and close for each
test?
```java
@BeforeEach
protected void startMiniCluster(@InjectMiniCluster MiniCluster
miniCluster) throws Exception {
if (!miniCluster.isRunning()) {
miniCluster.start();
}
}
@AfterEach
protected void stopMiniCluster(@InjectMiniCluster MiniCluster miniCluster)
throws Exception {
miniCluster.close();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
