tomtongue commented on code in PR #13021:
URL: https://github.com/apache/iceberg/pull/13021#discussion_r2084829380
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##########
@@ -314,20 +313,6 @@ private void
createBoundedStreams(StreamExecutionEnvironment env, int failAfter)
// test utilities copied from Flink's FileSourceTextLinesITCase
// ------------------------------------------------------------------------
- private static void runTestWithNewMiniCluster(ThrowingConsumer<MiniCluster,
Exception> testMethod)
- throws Exception {
- MiniClusterWithClientResource miniCluster = null;
- try {
- miniCluster = new
MiniClusterWithClientResource(MINI_CLUSTER_RESOURCE_CONFIG);
Review Comment:
Hmm, from my checking it, I think the same mini cluster is used for task
bounded and task contiunuous tests (as same as job manager tests). When I only
run `testBoundedWithTaskManagerFailover`, it succeeds, but when I run
`testBoundedWithTaskManagerFailover` and
`testContinuousWithTaskManagerFailover` in the same test run, the
`testContinuousWithTaskManagerFailover` is timed out.
For now, the numer of TaskManager is set to 1, so it seems that the other
TaskManager failover test waits until the other TaskManager test releases its
task manager. When I set the task manager number to 2, both tests for
TaskManager succeed
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##########
@@ -314,20 +313,6 @@ private void
createBoundedStreams(StreamExecutionEnvironment env, int failAfter)
// test utilities copied from Flink's FileSourceTextLinesITCase
// ------------------------------------------------------------------------
- private static void runTestWithNewMiniCluster(ThrowingConsumer<MiniCluster,
Exception> testMethod)
- throws Exception {
- MiniClusterWithClientResource miniCluster = null;
- try {
- miniCluster = new
MiniClusterWithClientResource(MINI_CLUSTER_RESOURCE_CONFIG);
Review Comment:
Hmm, from my checking it, I think the same mini cluster is used for task
bounded and task contiunuous tests (as same as job manager tests). When I only
run `testBoundedWithTaskManagerFailover`, it succeeds, but when I run
`testBoundedWithTaskManagerFailover` and
`testContinuousWithTaskManagerFailover` in the same test run, the
`testContinuousWithTaskManagerFailover` is timed out.
For now, the numer of TaskManager is set to 1, so it seems that the other
TaskManager failover test waits until the other TaskManager test releases its
task manager. When I set the task manager number to 2, both tests for
TaskManager succeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
