JeonDaehong commented on code in PR #13021:
URL: https://github.com/apache/iceberg/pull/13021#discussion_r2093234600
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##########
@@ -314,20 +313,6 @@ private void
createBoundedStreams(StreamExecutionEnvironment env, int failAfter)
// test utilities copied from Flink's FileSourceTextLinesITCase
// ------------------------------------------------------------------------
- private static void runTestWithNewMiniCluster(ThrowingConsumer<MiniCluster,
Exception> testMethod)
- throws Exception {
- MiniClusterWithClientResource miniCluster = null;
- try {
- miniCluster = new
MiniClusterWithClientResource(MINI_CLUSTER_RESOURCE_CONFIG);
Review Comment:
@nastra
Since this is my first contribution, everything feels quite difficult...
I’m really sorry to keep asking questions, but I would really appreciate a
bit more guidance.
From what I’ve checked, most of the code has already been migrated to JUnit
5. I'm currently a bit unsure about what exactly I should be working on (I’m
struggling to figure out the right direction).
My understanding was that I should update the code so that the project can
be built even after removing testImplementation libs.junit.vintage.engine from
the Flink-related Gradle configuration. But now I’m wondering if I may have
misunderstood something.
Since it’s my first contribution, I really want to do a good job — I’m sorry
again for asking so many questions…! 😢
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##########
@@ -314,20 +313,6 @@ private void
createBoundedStreams(StreamExecutionEnvironment env, int failAfter)
// test utilities copied from Flink's FileSourceTextLinesITCase
// ------------------------------------------------------------------------
- private static void runTestWithNewMiniCluster(ThrowingConsumer<MiniCluster,
Exception> testMethod)
- throws Exception {
- MiniClusterWithClientResource miniCluster = null;
- try {
- miniCluster = new
MiniClusterWithClientResource(MINI_CLUSTER_RESOURCE_CONFIG);
Review Comment:
Now I fully understand.
I was a bit slow to grasp it.
That was the part I really needed to resolve.
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
