nastra commented on code in PR #13021:
URL: https://github.com/apache/iceberg/pull/13021#discussion_r2086829622


##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##########
@@ -314,20 +313,6 @@ private void 
createBoundedStreams(StreamExecutionEnvironment env, int failAfter)
   // test utilities copied from Flink's FileSourceTextLinesITCase
   // ------------------------------------------------------------------------
 
-  private static void runTestWithNewMiniCluster(ThrowingConsumer<MiniCluster, 
Exception> testMethod)
-      throws Exception {
-    MiniClusterWithClientResource miniCluster = null;
-    try {
-      miniCluster = new 
MiniClusterWithClientResource(MINI_CLUSTER_RESOURCE_CONFIG);

Review Comment:
   @JeonDaehong yes this is an issue. See also my 
[comment](https://github.com/apache/iceberg/issues/12937#issuecomment-2871336066)
 on this. This means we can't easily remove JUnit4 from the classpath itself



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to