rdblue commented on code in PR #12682:
URL: https://github.com/apache/iceberg/pull/12682#discussion_r2052757722
##########
core/src/main/java/org/apache/iceberg/variants/Variants.java:
##########
@@ -200,4 +201,36 @@ public static VariantPrimitive<ByteBuffer> of(ByteBuffer
value) {
public static VariantPrimitive<String> of(String value) {
return new PrimitiveWrapper<>(PhysicalType.STRING, value);
}
+
+ public static VariantPrimitive<Long> ofTimentz(long value) {
+ return new PrimitiveWrapper<>(PhysicalType.TIMENTZ, value);
+ }
+
+ public static VariantPrimitive<Long> ofIsoTimentz(String value) {
+ return ofTimentz(DateTimeUtil.isoTimeToMicros(value));
+ }
+
+ public static VariantPrimitive<Long> ofTimestamptzNano(long value) {
+ return new PrimitiveWrapper<>(PhysicalType.TIMESTAMPTZNS, value);
+ }
+
+ public static VariantPrimitive<Long> ofIsoTimestamptzNano(String value) {
+ return ofTimestamptzNano(DateTimeUtil.isoTimestamptzToNanos(value));
+ }
+
+ public static VariantPrimitive<Long> ofTimestampntzNano(long value) {
+ return new PrimitiveWrapper<>(PhysicalType.TIMESTAMPNTZNS, value);
+ }
+
+ public static VariantPrimitive<Long> ofIsoTimestampntzNano(String value) {
+ return ofTimestampntzNano(DateTimeUtil.isoTimestampToNanos(value));
+ }
+
+ public static VariantPrimitive<UUID> ofUuid(UUID uuid) {
Review Comment:
UUID should be capitalized like the class name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
