rdblue commented on code in PR #12682:
URL: https://github.com/apache/iceberg/pull/12682#discussion_r2059086175
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetVariantVisitor.java:
##########
@@ -282,4 +284,18 @@ private static boolean isBinary(Type type) {
return type.isPrimitive()
&& type.asPrimitiveType().getPrimitiveTypeName() ==
PrimitiveTypeName.BINARY;
}
+
+ protected static PhysicalType type(TimestampLogicalTypeAnnotation timestamp)
{
Review Comment:
This isn't a good place for a conversion method. The visitor is a superclass
of both reader and writer builders, but it isn't where Parquet conversion logic
should live.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
