rdblue commented on code in PR #12682: URL: https://github.com/apache/iceberg/pull/12682#discussion_r2052749038
########## api/src/main/java/org/apache/iceberg/variants/Primitives.java: ########## @@ -36,7 +36,10 @@ class Primitives { static final int TYPE_FLOAT = 14; static final int TYPE_BINARY = 15; static final int TYPE_STRING = 16; - Review Comment: Why remove the space before `PRIMITIVE_TYPE_SHIFT`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org