rdblue commented on code in PR #12682:
URL: https://github.com/apache/iceberg/pull/12682#discussion_r2058811330
##########
parquet/src/main/java/org/apache/iceberg/parquet/VariantReaderBuilder.java:
##########
@@ -198,15 +201,41 @@ public Optional<VariantValueReader>
visit(DateLogicalTypeAnnotation ignored) {
@Override
public Optional<VariantValueReader> visit(TimestampLogicalTypeAnnotation
logical) {
- PhysicalType variantType =
- logical.isAdjustedToUTC() ? PhysicalType.TIMESTAMPTZ :
PhysicalType.TIMESTAMPNTZ;
+ PhysicalType variantType;
+
+ switch (logical.getUnit()) {
Review Comment:
Could this reuse the method from the writer builder? It looks like the same
logic, but inline here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
