rdblue commented on code in PR #12682:
URL: https://github.com/apache/iceberg/pull/12682#discussion_r2052750931


##########
api/src/main/java/org/apache/iceberg/variants/VariantObject.java:
##########
@@ -44,9 +46,13 @@ default VariantObject asObject() {
   static String asString(VariantObject object) {
     StringBuilder builder = new StringBuilder();
 
+    // Make the string deterministic

Review Comment:
   I think that the values should be in the field order from the object. Why 
does this need to be a different order?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to