wypoon commented on PR #12721: URL: https://github.com/apache/iceberg/pull/12721#issuecomment-2814205860
@danielcweeks I think you misunderstand me. I'm not advocating doing what the Spark and Flink modules now do, which is separate source sets for each version. I have worked hard to get the hive-metastore module build successfully against Hive 2, 3 and 4 using a single source set. I think we should maintain a single source set if possible, but I think we should **build**, not just **test** against Hive 2, 3 and 4. And I do agree about not producing multiple binaries. I have already avoid doing that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
