wypoon commented on PR #12721: URL: https://github.com/apache/iceberg/pull/12721#issuecomment-2819850170
@danielcweeks we are in agreement that we should produce a single set of artifacts for the hive-metastore module, that should have runtime compatibility across supported Hive versions. And I agree that the failure in publish is a problem. (The approach we took when we supported Spark 3.0 and 3.1 with a single set of artifacts was also to support runtime compatibility. I would just point out that the issue that was later discovered was a runtime compatibility issue; it was not discovered because there were no tests exercising the code path where that incompatibility occurred. However, the issue could have been discovered sooner if we had built against Spark 3.1.) I'd appreciate your help if you could open a PR against my branch with the gradle changes that you were able to get working. However, I'd propose that instead of building against Hive 2, we should build against Hive 4.0, and test against Hive 2.3, 3.1 and 4.0. Hive 2.3 and 3.1 are both EOL. Hive 4 is what will continue to change. By building against Hive 4, rather than an EOL version that won't change, we will catch any potential future breakage. This should also confirm that we do in fact have the backward compatibility that we plan to rely on, as Flink and Spark modules depend on the hive-metastore module and on Hive 2.3 currently. What do you think? (@pvary your thoughts too?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
