danielcweeks commented on PR #12721:
URL: https://github.com/apache/iceberg/pull/12721#issuecomment-2815929135
@wypoon I appreciate the effort put into getting this working, but I'm
concerned about the approach, complexity, and unintended impacts this approach
may have.
I see the goal here as ensuring that we have runtime compatibility, not
source-level compatibility across the different hive versions. If we want both
source and runtime compatibility, we should just produce separate artifacts and
have separate source/builds (not try to manage the same source across subtly
different incompatible versions). I don't think we want to go this route.
For example, I did a quick test to see what impact this would have on
publishing and it causes publish to fail:
```
* What went wrong:
Execution failed for task
':iceberg-hive3-metastore:publishApachePublicationToMavenLocal'.
> Failed to publish publication 'apache' to repository 'mavenLocal'
> Artifact iceberg-hive3-metastore-1.8.0-SNAPSHOT.jar wasn't produced by
this build.
```
I think @pvary's
[comment](https://github.com/apache/iceberg/pull/12721#discussion_r2034797879)
hits on some of the same concerns.
I'm happy to help get this up and running with test dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
