rdblue commented on code in PR #12672:
URL: https://github.com/apache/iceberg/pull/12672#discussion_r2047915344


##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/data/TestHelpers.java:
##########
@@ -887,11 +887,14 @@ public static void asMetadataRecord(GenericData.Record 
file) {
     file.put(3, 0); // specId
   }
 
+  // suppress the readable metrics and first-row-id that are not in manifest 
files

Review Comment:
   I thought we didn't use sentence case in non-javadoc comments because you 
get weird capitalized fragments and unnecessary PRs/commits to "fix" the case. 
Are these strong nits?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to