rdblue commented on code in PR #12593:
URL: https://github.com/apache/iceberg/pull/12593#discussion_r2011042229
##########
core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java:
##########
@@ -241,85 +257,110 @@ public void testDeletes() {
table.newDelete().deleteFile(file).commit();
// Deleting a file should create a new snapshot which should inherit
last-row-id from the
- // previous metadata and not
- // change last-row-id for this metadata.
+ // previous metadata and not change last-row-id for this metadata.
assertThat(table.currentSnapshot().firstRowId()).isEqualTo(30);
assertThat(table.currentSnapshot().addedRows()).isEqualTo(0);
assertThat(table.ops().current().nextRowId()).isEqualTo(30);
}
@TestTemplate
- public void testReplace() {
-
assumeThat(formatVersion).isGreaterThanOrEqualTo(TableMetadata.MIN_FORMAT_VERSION_ROW_LINEAGE);
+ public void testPositionDeletes() {
Review Comment:
@RussellSpitzer, I added tests for position and equality deletes. These were
previously failing because the record counts from delete manifests were also
used. Please take a look at the new test cases and the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
