rdblue commented on code in PR #12593:
URL: https://github.com/apache/iceberg/pull/12593#discussion_r2011047740
##########
core/src/main/java/org/apache/iceberg/BaseSnapshot.java:
##########
@@ -76,7 +87,7 @@ class BaseSnapshot implements Snapshot {
this.manifestListLocation = manifestList;
this.v1ManifestLocations = null;
this.firstRowId = firstRowId;
- this.addedRows = addedRows;
+ this.addedRows = firstRowId != null ? addedRows : null;
Review Comment:
To be slightly more permissive, I'm allowing `addedRows` to be passed, but
it is only propagated if `firstRowId` is non-null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
