RussellSpitzer commented on code in PR #12593:
URL: https://github.com/apache/iceberg/pull/12593#discussion_r2011055407
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -324,9 +348,8 @@ private Long calculateAddedRows(List<ManifestFile>
manifests) {
protected abstract Map<String, String> summary();
/** Returns the snapshot summary from the implementation and updates totals.
*/
- private Map<String, String> summary(TableMetadata previous) {
- Map<String, String> summary = summary();
-
+ private Map<String, String> summaryWithTotals(
Review Comment:
This will change the default output for all Table Versions right? Since
previously they could just produce nulls and now it produces an empty map?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
