rdblue commented on code in PR #12593:
URL: https://github.com/apache/iceberg/pull/12593#discussion_r2006578958
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -299,9 +290,8 @@ public String toString() {
Map<String, SnapshotRef> refs,
List<StatisticsFile> statisticsFiles,
List<PartitionStatisticsFile> partitionStatisticsFiles,
- List<MetadataUpdate> changes,
- boolean rowLineageEnabled,
- long nextRowId) {
+ long nextRowId,
+ List<MetadataUpdate> changes) {
Review Comment:
Not that this PR also restores the convention that changes are passed last
to the `TableMetadata` constructor. This is because changes are accumulated in
`TableMetadata.Builder` and are not part of the metadata definition. I'd prefer
not to mix changes into the actual table metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
