RussellSpitzer commented on code in PR #12593:
URL: https://github.com/apache/iceberg/pull/12593#discussion_r2010571837
##########
core/src/test/java/org/apache/iceberg/TestTableMetadata.java:
##########
@@ -232,8 +231,6 @@ public void testJsonConversion() throws Exception {
assertThat(metadata.statisticsFiles()).isEqualTo(statisticsFiles);
assertThat(metadata.partitionStatisticsFiles()).isEqualTo(partitionStatisticsFiles);
assertThat(metadata.refs()).isEqualTo(refs);
-
assertThat(metadata.rowLineageEnabled()).isEqualTo(expected.rowLineageEnabled());
- assertThat(metadata.nextRowId()).isEqualTo(expected.nextRowId());
Review Comment:
Yeah these just need a slight modification
##########
core/src/test/java/org/apache/iceberg/TestTableMetadata.java:
##########
@@ -342,8 +338,6 @@ public void testBackwardCompat() throws Exception {
.isEqualTo(previousSnapshot.allManifests(ops.io()));
assertThat(metadata.previousFiles()).isEqualTo(expected.previousFiles());
assertThat(metadata.snapshot(previousSnapshotId).schemaId()).isNull();
-
assertThat(metadata.rowLineageEnabled()).isEqualTo(expected.rowLineageEnabled());
Review Comment:
This assert should be dropped but the next one should be kept
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
