nastra commented on code in PR #12406:
URL: https://github.com/apache/iceberg/pull/12406#discussion_r1993670542
##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java:
##########
@@ -55,7 +59,50 @@ public class RESTCatalog
public RESTCatalog() {
this(
SessionCatalog.SessionContext.createEmpty(),
- config ->
HTTPClient.builder(config).uri(config.get(CatalogProperties.URI)).build());
+ config -> {
+ HTTPClient.Builder builder =
Review Comment:
so I think one possible issue that I can currently think of is that this
approach will only work for the REST catalog itself, but things like refreshing
vended credentials with S3/GCS
(`VendedCredentialsProvider`/`OAuth2RefreshCredentialsHandler`)or S3 signing
(`S3V4RestSignerClient`) won't work, since those places instantiate their own
HTTP client that wouldn't configure the proxy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
