kevinjqliu commented on code in PR #12299:
URL: https://github.com/apache/iceberg/pull/12299#discussion_r1990004839
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java:
##########
@@ -255,6 +256,48 @@ public void testNewInputStreamWithMultiRegionAccessPoint()
throws Exception {
validateRead(s3FileIO);
}
+ @Test
+ public void testNewInputStreamWithAnalyticsAccelerator() throws Exception {
+ s3.putObject(
+ PutObjectRequest.builder().bucket(bucketName).key(objectKey).build(),
+ RequestBody.fromBytes(contentBytes));
+ S3FileIO s3FileIO = new S3FileIO();
+ s3FileIO.initialize(
+ ImmutableMap.of(S3FileIOProperties.S3_ANALYTICS_ACCELERATOR_ENABLED,
String.valueOf(true)));
+ validateRead(s3FileIO);
+ }
+
+ @Test
+ public void testNewInputStreamWithAnalyticsAcceleratorAndCRT() throws
Exception {
+ s3.putObject(
+ PutObjectRequest.builder().bucket(bucketName).key(objectKey).build(),
+ RequestBody.fromBytes(contentBytes));
+ S3FileIO s3FileIO = new S3FileIO();
+ s3FileIO.initialize(
+ ImmutableMap.of(
+ S3FileIOProperties.S3_ANALYTICS_ACCELERATOR_ENABLED,
+ String.valueOf(true),
+ S3FileIOProperties.S3_CRT_ENABLED,
+ String.valueOf(true)));
+ validateRead(s3FileIO);
+ }
+
+ @Test
+ public void testNewInputStreamWithAnalyticsAcceleratorCustomConfigured()
throws Exception {
+ final String prefetchingMode = "logicalio.prefetching.mode";
+ final String s3Uri = String.format("s3://%s/%s/%s", bucketName, prefix,
"testFile.parquet");
Review Comment:
```suggestion
final String s3Uri = String.format("s3://%s/%s/%s.parquet", bucketName,
prefix, objectKey);
```
what about?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
