kevinjqliu commented on code in PR #12299:
URL: https://github.com/apache/iceberg/pull/12299#discussion_r1990053279


##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputFile.java:
##########
@@ -75,7 +95,7 @@ public PositionOutputStream createOrOverwrite() {
 
   @Override
   public InputFile toInputFile() {
-    return new S3InputFile(client(), uri(), null, s3FileIOProperties(), 
metrics());
+    return new S3InputFile(client(), asyncClient(), uri(), null, 
s3FileIOProperties(), metrics());

Review Comment:
   This will use the new `asyncClient` by default. we should branch and gate 
this with `shouldUseAsyncClient`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to