geruh commented on code in PR #12299:
URL: https://github.com/apache/iceberg/pull/12299#discussion_r1989952400
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -118,6 +119,14 @@ public S3Client s3() {
.build();
}
+ @Override
+ public S3AsyncClient s3Async() {
Review Comment:
Since we are building AWS clients, we should follow the conventions here for
passing in the `s3FileIOProperties` to client builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
