kevinjqliu commented on PR #12299: URL: https://github.com/apache/iceberg/pull/12299#issuecomment-2715494642
> If you are using the normal code path today with the feature off, with all the separated code paths, you should not be affected at all. yea looking at `aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java`, that seems to be true. This PR pulls the accelerator library in as a dependency but the feature is turned off by default. I have some concerns around keeping track of the state from the 2 different s3 clients, the original and the async one. We'd want to make sure the correct one is used and initiated properly. Since S3FileIO is widely used in Iceberg, it would be good to get more eyes on this PR. I'll do another pass to verify that there are no behavior changes when the async client is not used. It would also be great to outline the migration path going forward. Are there plans to replace the current s3 client with the async client? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
