jackye1995 commented on code in PR #12299: URL: https://github.com/apache/iceberg/pull/12299#discussion_r1989966659
########## aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java: ########## @@ -118,6 +119,14 @@ public S3Client s3() { .build(); } + @Override + public S3AsyncClient s3Async() { Review Comment: I was fine with it for now because currently most of the mutations do not work with any async or CRT clients, we probably need another dedicated PR to plumb through all those logic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org