kevinjqliu commented on issue #1708: URL: https://github.com/apache/iceberg-python/issues/1708#issuecomment-2676383127
Catching up with the context from #1453. These are the different scenarios i can think of: 1. `region` is not provided (`region=None`) 2. right `region` is provided. region is the same as the bucket region 3. wrong `region` is provided For (1), I agree we shouldn't emit a warning. This will address #1705 For (2), its no-op For (3), the provided `region` is overridden with the correct `region` from `resolve_s3_region`, so we should emit a warning Also, taking a step back, I wonder if we should be more explicit about when to resolve region (run `resolve_s3_region`). It is currently turned on by default. Should we add a config flag to enable this behavior and set the default to False? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
