kevinjqliu commented on issue #1708: URL: https://github.com/apache/iceberg-python/issues/1708#issuecomment-2676418044
> Also, taking a step back, I wonder if we should be more explicit about when to resolve region (run resolve_s3_region). It is currently turned on by default. Should we add a config flag to enable this behavior and set the default to False? Im leaning towards making `resolve_s3_region` an opt-in behavior and have it be turned off by default. Even with caching (#1709), running `PYTEST_ARGS="-s" make test` emits 136 lines of `_cached_resolve_s3_region` logs after I added a log line. I think until we can override the `endpoint_url` for `resolve_s3_region` (https://github.com/apache/arrow/issues/43713), we should not have this on by default. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
